Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugs of the script for mesh format conversion Gmsh -> Specfem2d #1211

Merged
merged 3 commits into from Mar 30, 2024

Conversation

mnagaso
Copy link

@mnagaso mnagaso commented Mar 29, 2024

This is an important update for EXAMPLES/Gmsh_example_CPML_MPI.

The python script for converting the mesh file format from Gmsh to Specfem2D had some bugs on:

  • writing node ids.
  • dupilcated elements' edges definitions between acoustic-elastic boundary (thus no energy transition at the interface).

Additionally, a new function has been added for inserting a transition layer between PML layers and a non-PML domain, which may useful to stabilize the simulation.

All the debugs are on the scripts in this example, thus no effect on the main code.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (32c7839) to head (9739716).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1211      +/-   ##
==========================================
- Coverage   54.64%   54.63%   -0.01%     
==========================================
  Files         164      164              
  Lines       30233    30233              
==========================================
- Hits        16520    16519       -1     
- Misses      13713    13714       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeter danielpeter merged commit 4e6f61b into SPECFEM:devel Mar 30, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants