-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert events into MSSQL in deterministic order #20
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
src/Cedar.EventStore.MsSql2008.Tests/EventStoreAcceptanceTests.ReadLongStreamInPages.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
namespace Cedar.EventStore | ||
{ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Threading.Tasks; | ||
using System.Linq; | ||
using Cedar.EventStore.Streams; | ||
using Shouldly; | ||
using Xunit; | ||
|
||
public partial class EventStoreAcceptanceTests | ||
{ | ||
[Fact] | ||
public async Task Given_large_event_stream_can_be_read_back_in_pages() | ||
{ | ||
using (var fixture = GetFixture()) | ||
{ | ||
using (var eventStore = await fixture.GetEventStore()) | ||
{ | ||
var eventsToWrite = CreateNewStreamEvents(); | ||
|
||
await eventStore.AppendToStream("stream-1", ExpectedVersion.NoStream, eventsToWrite); | ||
|
||
|
||
var readEvents = await new PagedEventStore(eventStore).GetAsync("stream-1"); | ||
|
||
readEvents.Count().ShouldBe(eventsToWrite.Length); | ||
} | ||
} | ||
} | ||
|
||
private static NewStreamEvent[] CreateNewStreamEvents() | ||
{ | ||
var eventsToWrite = new List<NewStreamEvent>(); | ||
var largeStreamCount = 7500; | ||
for (int i = 0; i < largeStreamCount; i++) | ||
{ | ||
var envelope = new NewStreamEvent(Guid.NewGuid(), $"event{i}", "{}", $"{i}"); | ||
|
||
eventsToWrite.Add(envelope); | ||
} | ||
|
||
return eventsToWrite.ToArray(); | ||
} | ||
} | ||
|
||
public class PagedEventStore | ||
{ | ||
private readonly IEventStore _eventStore; | ||
|
||
public PagedEventStore(IEventStore eventStore) | ||
{ | ||
_eventStore = eventStore; | ||
} | ||
|
||
public async Task<IEnumerable<StreamEvent>> GetAsync(string streamName) | ||
{ | ||
var start = 0; | ||
const int BatchSize = 500; | ||
|
||
StreamEventsPage eventsPage; | ||
var events = new List<StreamEvent>(); | ||
|
||
do | ||
{ | ||
eventsPage = await _eventStore.ReadStreamForwards(streamName, start, BatchSize); | ||
|
||
if (eventsPage.Status == PageReadStatus.StreamDeleted) | ||
{ | ||
throw new Exception("Stream deleted"); | ||
} | ||
|
||
if (eventsPage.Status == PageReadStatus.StreamNotFound) | ||
{ | ||
throw new Exception("Stream not found"); | ||
} | ||
|
||
events.AddRange( | ||
eventsPage.Events); | ||
|
||
start = eventsPage.NextStreamVersion; | ||
} | ||
while (!eventsPage.IsEndOfStream); | ||
|
||
return events; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yreynhout looks simple enough fix :)