Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid measuring video streaming in background #425

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Avoid measuring video streaming in background #425

merged 4 commits into from
Jun 20, 2023

Conversation

waliid
Copy link
Member

@waliid waliid commented Jun 20, 2023 •
edited
Loading

Description

This PR allows us to ignore ComScore streaming analytics in background.

Changes made

  • The usagePropertiesAutoUpdateMode property is not used anymore.
  • New state ApplicationState has been introduced.
  • A new publisher applicationStatePublisher has been added.
  • ComScore streaming analytics are paused when the app is in the background.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@waliid waliid linked an issue Jun 20, 2023 that may be closed by this pull request
Avoid measuring video streaming in background #419
Closed
2 tasks
@waliid waliid changed the title 419 avoid measuring video streaming in background Avoid measuring video streaming in background Jun 20, 2023
@defagos defagos added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@waliid waliid added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit 02a7be8 Jun 20, 2023
@waliid waliid deleted the 419-avoid-measuring-video-streaming-in-background branch June 20, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid measuring video streaming in background
2 participants
@waliid @defagos