-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deliver player metadata #808
Merged
defagos
merged 91 commits into
main
from
807-update-type-erasure-implementation-in-metadata-poc
Mar 26, 2024
Merged
Deliver player metadata #808
defagos
merged 91 commits into
main
from
807-update-type-erasure-implementation-in-metadata-poc
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
defagos
approved these changes
Mar 26, 2024
defagos
reviewed
Mar 26, 2024
defagos
reviewed
Mar 26, 2024
defagos
approved these changes
Mar 26, 2024
waliid
force-pushed
the
807-update-type-erasure-implementation-in-metadata-poc
branch
from
March 26, 2024 14:39
80b992f
to
ae77a87
Compare
defagos
approved these changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 26, 2024
defagos
deleted the
807-update-type-erasure-implementation-in-metadata-poc
branch
March 26, 2024 15:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows us to deliver the metadata of the current item being played.
Important
Changes made
delayIfNeeded
.AssetMetadata
,Assetable
.MetadataAdapter
,AssetContent
,CommonMetadata
,TrackerLifeCycle
.PlayerMetadata
toPlayerItemMetadata
.metadata
on the player.receiveOnMainThread
.Checklist