Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver player metadata #808

Merged
merged 91 commits into from
Mar 26, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Mar 26, 2024

Description

This PR allows us to deliver the metadata of the current item being played.

Important

  • The documentation hasn't been updated yet and will be done in another PR. An issue has been created for this purpose.
  • During our development we've noticed that several improvements could be done. These improvements will be made in other PRs.

Changes made

  • Adds delayIfNeeded.
  • Removes AssetMetadata, Assetable.
  • Introduces MetadataAdapter, AssetContent, CommonMetadata, TrackerLifeCycle.
  • Renames PlayerMetadata to PlayerItemMetadata.
  • Introduces published property metadata on the player.
  • Fixes receiveOnMainThread.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid linked an issue Mar 26, 2024 that may be closed by this pull request
4 tasks
@waliid waliid marked this pull request as ready for review March 26, 2024 12:58
@waliid waliid enabled auto-merge March 26, 2024 13:02
@waliid waliid force-pushed the 807-update-type-erasure-implementation-in-metadata-poc branch from 80b992f to ae77a87 Compare March 26, 2024 14:39
@waliid waliid requested a review from defagos March 26, 2024 14:48
@waliid waliid added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@defagos defagos added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit b82fd13 Mar 26, 2024
6 checks passed
@defagos defagos deleted the 807-update-type-erasure-implementation-in-metadata-poc branch March 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update type erasure implementation in metadata PoC
2 participants