Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing a user-friendly API for AVMetadataItem construction #809

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Introducing a user-friendly API for AVMetadataItem construction #809

merged 2 commits into from
Apr 2, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Mar 26, 2024

Description

Self-explanatory.

Changes made

  • Introduces an extension on AVMetadataItem for easier initialization.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid added the enhancement New feature or request label Mar 26, 2024
@waliid waliid self-assigned this Mar 26, 2024
@waliid waliid marked this pull request as draft March 26, 2024 14:47
Base automatically changed from 807-update-type-erasure-implementation-in-metadata-poc to main March 26, 2024 15:27
@waliid waliid marked this pull request as ready for review March 28, 2024 11:33
defagos
defagos approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@defagos defagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this API won't change in a very near future but this is still an improvement over what we have today. Thanks.

@defagos defagos added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 3dc84c7 Apr 2, 2024
6 checks passed
@defagos defagos deleted the api-for-metadata-item branch April 2, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waliid @defagos