Polish implementation and documentation #814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a few minor implementation and documentation improvements found randomly when looking at the code.
Changes made
Internal
folder that was not contributing much to the project structure.CommandersActService.start(with:)
implementation to avoid early return. The optional binding is an artifact of lacking nullability in Commanders Act headers, we should never skip what's next. We could also replace the optional binding with a force unwrap in this case but there is not much to gain IMHO.Checklist