Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display chapters in iOS demo #832

Merged
merged 27 commits into from
Apr 19, 2024
Merged

Display chapters in iOS demo #832

merged 27 commits into from
Apr 19, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Apr 19, 2024 •
edited by defagos

Description

Self-explanatory.

Changes made

  • The PlaybackSlider has been improved (improved interaction area around the slider).
  • A ChaptersPlayerView has been introduced.
  • The global player layout has been improved.

Illustrations

iPhone iPad
iphone ipad

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

waliid and others added 27 commits April 18, 2024 14:09
@waliid
Fix layout
63c8698
@waliid
Add a top bar style
304fd9f
@waliid
Fix metadata display in fullscreen
5387191
@waliid
Setup chapters view
f062c0f
@waliid
Add a playback view
c7b2d8a
@waliid
Add chapters
93da917
@waliid
Highlight the current chapter
f6790f9
@waliid
Seek with more precision
a1260c8
@waliid
Move cell related to chapters into a more relevant section
46c9454
@waliid
Use smooth time instead of the current time
cce3d3f
@defagos
Reduce bottom space
0a29d67
@defagos
Use capsule shorthand
3cd98f9
@defagos
Improve slider interaction area
b215ca2
@defagos
Reduce top bar height
82c636d
@defagos
Polish implementation
5ca30d2
@defagos
Seek within range to ensure immediately correct selection
531e608
@defagos
Display chapters when maximized
012c3cc
@waliid
Improve chapter view layout
9c3e87f
@waliid
Add an animation
a9fe66b
@waliid
Open chapters view for IL content
58f37da
@waliid
Add picture in picture for chapters
7dc6901
@waliid
Avoid displaying chapters view if not needed
c9e6e5d
@waliid
Display metadata in all cases
fcc7ff0
@waliid
Add padding for some close buttons
d0f629e
@waliid
Rename ChaptersView
87bf601
@waliid
Factorize width
4131402
@waliid
Avoid using custom layout on tvOS
ff9cb9e
@waliid waliid linked an issue Apr 19, 2024 that may be closed by this pull request
Display chapters in iOS demo #816
Closed
2 tasks
@waliid waliid enabled auto-merge April 19, 2024 10:38
@waliid waliid added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 6b5fc5f Apr 19, 2024
6 checks passed
@waliid waliid deleted the 816-display-chapters-in-ios-demo branch April 19, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display chapters in iOS demo
2 participants
@waliid @defagos