Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ChapterMetadata to Chapter #833

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Rename ChapterMetadata to Chapter #833

merged 2 commits into from
Apr 19, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Apr 19, 2024

Description

Self-explanatory.

Changes made

  • The media composition Chapter has been embedded in the MediaCompositon (extension).
  • The ChapterMetadata has been renamed to Chapter.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid self-assigned this Apr 19, 2024
Base automatically changed from 816-display-chapters-in-ios-demo to main April 19, 2024 11:19
@waliid waliid enabled auto-merge April 19, 2024 11:37
@waliid waliid added this pull request to the merge queue Apr 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 19, 2024
@waliid waliid added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 18ee0ba Apr 19, 2024
6 checks passed
@waliid waliid deleted the renaming-proposal branch April 19, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees

@waliid waliid

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waliid @defagos