Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable advanced Picture in Picture and Control Center integration for the chapter-supporting player #836

Merged
merged 5 commits into from
Apr 21, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 20, 2024

Description

This PR enables advanced Picture in Picture and Control Center integration for the chapter-supporting player. This was initially omitted but felt awkward when navigating SRG SSR content from a demo user perspective.

Changes made

  • Enable advanced PiP for the player supporting chapters.
  • Enable Control Center integration for the player supporting chapters.
  • Revisit the implementation to have correct animations during PiP restoration. Instead of manual state registration it suffices to split the view into subviews with local Player observation.
  • Track the player view.
  • Make highlighted chapters slightly more prominent.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this Apr 20, 2024
@defagos defagos added the enhancement New feature or request label Apr 20, 2024
@defagos defagos enabled auto-merge April 20, 2024 07:31
@defagos defagos added this to the Metadata milestone Apr 20, 2024
@defagos defagos force-pushed the improve-chapter-player-integration branch from 81167b7 to ba348b8 Compare April 21, 2024 13:26
@defagos defagos added this pull request to the merge queue Apr 21, 2024
Merged via the queue into main with commit 5f4e94b Apr 21, 2024
6 checks passed
@defagos defagos deleted the improve-chapter-player-integration branch April 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants