Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never return chapters for audio content #842

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Never return chapters for audio content #842

merged 1 commit into from
Apr 23, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 22, 2024

Description

This PR removes (video) chapters which might still delivered for audio content, e.g. in Forum.

Changes made

Self-explanatory.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this Apr 22, 2024
@defagos defagos added this to the Metadata milestone Apr 22, 2024
@defagos defagos added the bug Something isn't working label Apr 22, 2024
@defagos defagos requested review from amtins and waliid April 22, 2024 09:29
@defagos defagos enabled auto-merge April 22, 2024 09:35
@defagos defagos added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit ce46a19 Apr 23, 2024
6 checks passed
@defagos defagos deleted the audio-chapter-fix branch April 23, 2024 06:32
@amtins amtins mentioned this pull request Apr 23, 2024
Closed
amtins added a commit to SRGSSR/pillarbox-web that referenced this pull request Apr 23, 2024
@amtins
fix(media-composition): remove audio chapters
ab870a0 
Fixes #245 by removing audio chapters from `mediaComposition`. The reason for
this is that audio chaptering is physical, not logical. This results in data
inconsistency and prevents chapter change events from being sent.

- delete audio chapters from audio URNs or audio chapters from video URNs

Ref: SRGSSR/pillarbox-apple#842
@amtins amtins mentioned this pull request Apr 23, 2024
Merged
amtins added a commit to SRGSSR/pillarbox-web that referenced this pull request Apr 24, 2024
@amtins
fix(media-composition): remove audio chapters
48e3c6d 
Fixes #245 by removing audio chapters from `mediaComposition`. The reason for
this is that audio chaptering is physical, not logical. This results in data
inconsistency and prevents chapter change events from being sent.

- delete audio chapters from audio URNs or audio chapters from video URNs

Ref: SRGSSR/pillarbox-apple#842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

@amtins amtins Awaiting requested review from amtins

Assignees

@defagos defagos

Labels
bug Something isn't working
Projects
Pillarbox
Status: ✅ Done
Milestone
Metadata
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@defagos @waliid