Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support opening and end credits #850

Merged
merged 27 commits into from
Apr 26, 2024
Merged

Support opening and end credits #850

merged 27 commits into from
Apr 26, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Apr 26, 2024 •
edited

Description

This PR allows us to manage the opening and closing credits.

Changes made

  • The opening and closing credits are parsed from the MediaComposition.
  • A TimeRange object has been introduced.
  • A ContextualAction object has been introduced.
  • A contextualActions API has been added for the SystemVideoView
  • An example with opening and closing credit has been hardcoded in the demo app.
  • All media composition objects files have been renamed.
  • A new property timeRanges has been added to PlayerMetadata.

Render

iOS tvOS
iphone tvOS

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

waliid and others added 23 commits April 25, 2024 11:27
@waliid
Add a MediaComposition object to get credits
382a983
@waliid
Rename some MediaComposition extention files
8419426
@waliid
Parse the MediaComposition to get the credits
c4c78ce
@waliid
Improve naming
566ba63
@waliid
Introduce PlaybackRange
37f96b1
@waliid
Improve naming
062d410
@waliid
Map MediaComposition time intervals to PlayerMetadata time ranges
cafdaf2
@waliid
Update doc
d67a1ec
@waliid
Add skip button
53c92e2
@waliid
Improve skip button display
3bfaaa6
@defagos
Improve skip button visibility management
7c1fe75
@defagos
Improve view hierarchy
6a3da47
@waliid
Improve encapsulation
7275aa3
@waliid
Introduce contextual actions
29acbfa
@waliid
Add time ranges to templates
9a604ef
@waliid
Add skip button on tvOS interface
b99ddd2
@waliid
Introduce ContextualAction
e3a9f52
@waliid
Use contextual action
74704ec
@waliid
Manage opening and closing credits
a5221c4
@waliid
Wrap SystemVideoView to avoid refreshing the entire PlaybackView
a29ead8
@waliid
Mark tvOS API not available on iOS
02838ab
@waliid
Improve TimeRange API
eba5c3d
@defagos
Fix compilation issue
fcc5aad
@waliid waliid linked an issue Apr 26, 2024 that may be closed by this pull request
Support opening and end credits #845
Closed
6 tasks
@defagos defagos enabled auto-merge April 26, 2024 12:50
@defagos defagos added this pull request to the merge queue Apr 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2024
@defagos defagos added this pull request to the merge queue Apr 26, 2024
@defagos defagos removed this pull request from the merge queue due to a manual request Apr 26, 2024
@defagos defagos added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 78c0fda Apr 26, 2024
6 checks passed
@defagos defagos deleted the 845-support-opening-and-end-credits branch April 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support opening and end credits
2 participants
@waliid @defagos