Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle blocked time ranges #853

Merged
merged 37 commits into from
Apr 30, 2024
Merged

Handle blocked time ranges #853

merged 37 commits into from
Apr 30, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Apr 30, 2024 •
edited

Description

This PR allows us to manage some part of the stream which are marked as blocked/forbidden.

Changes made

  • The item closure configuration has been replaced by an object (PlayerItemConfiguration).
  • Seeking in a blocked range is not allowed anymore.
  • Contents with a blocked part can now be played (excluding the blocked part).
  • Blocked parts of a stream are jumped.
  • On tvOS the blocked parts of the stream have been replaced by interstitials.
  • A new section with time ranges has been added in the demo app.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

waliid and others added 30 commits April 26, 2024 15:40
@waliid
Parse more media composition segment fields
2bf15af
@waliid
Add blocked segment time ranges to the MediaMetadata
bce5255
@waliid
Add an hardcoded example for blocked time ranges
e3e0aab
@waliid
Avoid blocking content which contains blocked segments
8c48e5b
@waliid
Display skip button only for credits
2174335
@waliid
Add tvOS interstials to avoid seeking inside a blocked time range
dfd6eb6
@defagos
Adjust skip button appearance
ba89144
@waliid
Add testOnDemandStartInBlockedTimeRange
a5cf10b
@waliid
Move blocked time range tests into a dedicated file
1264e57
@waliid
Add testSeekInBlockedTimeRange
e4da603
@waliid
Improve testSeekInBlockedTimeRange
b1a9bd6
@waliid
Add testBlockedTimeRangeTraversal
f1a1275
@waliid
Add after method as extension of CMTime
d36baa4
@waliid
Remove duplicated test
3f24eac
@waliid
Rename file
8e3905a
@waliid
Fix testBlockedTimeRangeTraversal
160d507
@defagos
Turn item configuration into a type
30d5670
@defagos
Make API more expressive
d761156
@defagos
Remove now irrelevant test
4a68b30
@waliid
Fix testSeekInBlockedTimeRange
66090c6
@waliid
Rename test suite
448cd76
@waliid
Add CMTimeRangeTests
c10d39c
@waliid
Fix interstitials provided for tvOS
1d94a4f
@defagos
Remove less relevant comment
5595e6b
@defagos
Make implementation more expressive
1270fd5
@defagos
Improve publisher name
9ebdc73
@defagos
Rename variable
d48c90f
@defagos
Remove import
1b403e5
@waliid
Avoid to convert from TimeRange to CMTimeRange several times
13a0fa6
@defagos
Fix documentation
be3e728
@waliid waliid linked an issue Apr 30, 2024 that may be closed by this pull request
Handle blocked time ranges #851
Closed
7 tasks
@waliid waliid enabled auto-merge April 30, 2024 13:07
@waliid waliid added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit eab0c9f Apr 30, 2024
6 checks passed
@waliid waliid deleted the 851-handle-blocked-time-ranges branch April 30, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle blocked time ranges
2 participants
@waliid @defagos