Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable chapter support in the main custom player layout #855

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Enable chapter support in the main custom player layout #855

merged 1 commit into from
Apr 30, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Apr 30, 2024

Description

This PR reduces the number of custom layouts by enabling support for chapters in the main custom player layout.

Changes made

  • Merge ChaptersPlayerView into PlayerView.
  • Remove chapter display on tvOS.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Apr 30, 2024 that may be closed by this pull request
Make player with chapters the default custom player #854
Closed
2 tasks
@defagos defagos enabled auto-merge April 30, 2024 14:11
@defagos defagos added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit f6112d1 Apr 30, 2024
6 checks passed
@defagos defagos deleted the 854-make-player-with-chapters-the-default-custom-player branch April 30, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make player with chapters the default custom player
2 participants
@defagos @waliid