Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage image retrieval at the player level #860

Merged
merged 20 commits into from
May 3, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 3, 2024

Description

This PR moves image retrieval to the player level, making implementation of custom asset loading publishers even simpler.

Changes made

  • Replace images with image sources which can be used to provide either an image or a URL (URL requests were considered but will be added later if really meaningful).
  • Implement publishers for image sources, chapters and PlayerMetadata so that each of them can published updates of themselves when images are loaded.
  • Remove image retrieval from Core Business entirely.
  • Update enum style for consistency.
  • Add missing image width constant.
  • Use default URL sessions (hopefully not needed anymore, see Try to mitigate tests that sometimes fail  #272).

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue May 3, 2024 that may be closed by this pull request
4 tasks
@defagos defagos enabled auto-merge May 3, 2024 09:29
@defagos defagos force-pushed the 837-manage-image-retrieval-at-the-player-level branch from 66d760d to 3f0b29f Compare May 3, 2024 09:34
@defagos defagos added this pull request to the merge queue May 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 3, 2024
@defagos defagos added this pull request to the merge queue May 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 3, 2024
@defagos defagos added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 2a9b62b May 3, 2024
6 checks passed
@defagos defagos deleted the 837-manage-image-retrieval-at-the-player-level branch May 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Manage image retrieval at the player level
2 participants