Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undesired seek in overlapping time ranges #863

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix undesired seek in overlapping time ranges #863

merged 2 commits into from
May 3, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 3, 2024

Description

This PR fixes #861.

Changes made

  • Add test reproducing the issue.
  • Fix the issue by applying the same flattening approach as for interstitials. To avoid repeatedly performing the same work, flattening is made once and the result cached.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue May 3, 2024 that may be closed by this pull request
Fix undesired seek in overlapping time ranges #861
Closed
1 task
@defagos defagos enabled auto-merge May 3, 2024 13:00
@defagos defagos added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 62f1592 May 3, 2024
6 checks passed
@defagos defagos deleted the 861-fix-undesired-seek-in-nested-time-ranges branch May 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix undesired seek in overlapping time ranges
2 participants
@defagos @waliid