Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display artwork image for audio #866

Merged
merged 3 commits into from
May 4, 2024
Merged

Display artwork image for audio #866

merged 3 commits into from
May 4, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 3, 2024 •
edited

Description

This PR updates the custom player UI to display an artwork image, if available, when audio is played.

Before After
Before After

Changes made

  • Display image when available.
  • Remove audio image placeholder when no image is available.
  • Slightly increase control overlay opacity.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this May 3, 2024
@defagos defagos added the enhancement New feature or request label May 3, 2024
@defagos defagos added this to the Metadata milestone May 3, 2024
@defagos defagos enabled auto-merge May 4, 2024 06:30
@defagos defagos added this pull request to the merge queue May 4, 2024
Merged via the queue into main with commit 641130d May 4, 2024
6 checks passed
@defagos defagos deleted the audio-artwork branch May 4, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
Metadata
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@defagos @waliid