Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new API for localization #869

Merged
merged 1 commit into from
May 7, 2024
Merged

Use new API for localization #869

merged 1 commit into from
May 7, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented May 7, 2024

Description

Self-explanatory.

Changes made

  • Uses String instead of NSLocalizedString

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid added the enhancement New feature or request label May 7, 2024
@waliid waliid self-assigned this May 7, 2024
@defagos defagos added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@waliid waliid added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 303f803 May 7, 2024
6 checks passed
@waliid waliid deleted the use-new-api-string-localized branch May 7, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waliid @defagos