Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply current demo settings to player instances #872

Merged
merged 1 commit into from
May 8, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 8, 2024

Description

This PR fixes a regression recently introduced in the demo. Some settings changes, most notably how external playback behaves while mirroring or how playlists are navigated, were not applied anymore until the application was restarted.

Changes made

  • Fix player configuration to reflect current demo settings.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this May 8, 2024
@defagos defagos added the bug Something isn't working label May 8, 2024
@defagos defagos enabled auto-merge May 8, 2024 07:15
@defagos defagos added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@defagos defagos added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit a677e9c May 8, 2024
6 checks passed
@defagos defagos deleted the demo-settings-update branch May 8, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants