Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent controls from being toggled while interacting #874

Merged
merged 1 commit into from
May 12, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 8, 2024

Description

This PR fixes the following minor custom player issue, in a way that is consistent with the system player UX:

  • Open a video content with the custom player.
  • Use the slider to navigate the content.
  • While sliding tap somewhere on the UI.

Currently the controls can be toggled. This should not be the case.

Changes made

  • Disable toggle gesture while interacting.
  • Improve gesture implementation.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos self-assigned this May 8, 2024
@defagos defagos added the enhancement New feature or request label May 8, 2024
@defagos defagos added this pull request to the merge queue May 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2024
@defagos defagos added this pull request to the merge queue May 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2024
@defagos defagos added this pull request to the merge queue May 12, 2024
Merged via the queue into main with commit 600ec94 May 12, 2024
6 checks passed
@defagos defagos deleted the slider-interaction-fix branch May 12, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants