Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable automatic now playing info updates on iOS #875

Merged
merged 2 commits into from
May 13, 2024
Merged

Disable automatic now playing info updates on iOS #875

merged 2 commits into from
May 13, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented May 13, 2024 •
edited

Description

This PR disables automatic now playing info updates on iOS so that becomeActive() is required for proper Control Center integration on this platform.

Changes made

  • Disable AVPlayerViewController now playing info updates on iOS. The code is a bit redundant but factoring common AVPlayerViewController configuration would probably have lead to a clunky internal API concept anyway.
  • Due to markdown-cli updates on CI agents the linting configuration had to be updated as well.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue May 13, 2024 that may be closed by this pull request
Disable automatic Control Center integration provided by the system player on iOS #873
Closed
1 task
@defagos defagos enabled auto-merge May 13, 2024 06:39
@defagos defagos added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@waliid waliid added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@defagos defagos enabled auto-merge May 13, 2024 07:22
@defagos defagos added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@defagos defagos added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit d9ce8ae May 13, 2024
6 checks passed
@defagos defagos deleted the 873-disable-automatic-control-center-integration-provided-by-the-system-player-on-ios branch May 13, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees

@defagos defagos

@waliid waliid

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable automatic Control Center integration provided by the system player on iOS
2 participants
@defagos @waliid