Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load chapters and artwork images lazily #879

Merged
merged 14 commits into from
May 15, 2024
Merged

Conversation

waliid
Copy link
Member

@waliid waliid commented May 15, 2024

Description

This PR allows us to load chapters and artwork images only when these are used.

Changes made

  • Introduces NowPlaying and replaces NowPlayingInfo by NowPlaying.Info
  • The now playing info are merged only when the info property is accessed.
  • Introduces ImageSource.
  • The PlayerMedatadata uses an image source instead of using an image.
  • Adds LazyImage to load lazily an image from a given image source.
  • Adds LazyUIImage to load lazily an UIImage from a given image source.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid linked an issue May 15, 2024 that may be closed by this pull request
8 tasks
@defagos defagos added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@defagos defagos added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 49623ed May 15, 2024
6 checks passed
@defagos defagos deleted the 859-load-images-lazily branch May 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Load images lazily
2 participants