Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capped times delivered by a progress tracker at the live edge #880

Conversation

defagos
Copy link
Member

@defagos defagos commented May 15, 2024

Description

This PR fixes incorrectly capped times delivered by a ProgressTracker at the live edge of a DVR livestream.

Changes made

  • Revisit implementation to store uncapped internal progress.
  • Always expose progress in 0...1 publicly, but use internal uncapped progress for time construction.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue May 15, 2024 that may be closed by this pull request
1 task
@defagos defagos force-pushed the 878-progress-tracker-time-is-sometimes-stuck-when-playing-dvr-livestreams branch from e54b879 to 6e17a8d Compare May 15, 2024 13:09
@defagos defagos enabled auto-merge May 15, 2024 14:10
@defagos defagos added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@defagos defagos added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 5a87ff8 May 15, 2024
6 checks passed
@defagos defagos deleted the 878-progress-tracker-time-is-sometimes-stuck-when-playing-dvr-livestreams branch May 15, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Progress tracker time is sometimes stuck when playing DVR livestreams
2 participants