Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the loading indicator to the right when the UI is hidden #886

Merged
merged 2 commits into from
May 16, 2024
Merged

Align the loading indicator to the right when the UI is hidden #886

merged 2 commits into from
May 16, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented May 16, 2024

Description

Self-explanatory.

Changes made

Bad alignment Good alignment
bad good

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid enabled auto-merge May 16, 2024 06:08
@waliid waliid self-assigned this May 16, 2024
@waliid waliid added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 59afca0 May 16, 2024
6 checks passed
@waliid waliid deleted the fix-loading-indicator-position branch May 16, 2024 07:16
@defagos defagos added the enhancement New feature or request label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waliid @defagos