Mcsat check model with hint API method #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahmed-irfan
commented
Nov 1, 2023
ahmed-irfan
commented
- Adds the new api method
- Adds a test to check the api method
- Updates the documentation
disteph
reviewed
Nov 4, 2023
| mcsat_value_destruct(&value); | ||
| } | ||
|
|
||
| mcsat_pop(mcsat); |
There was a problem hiding this comment.
Does the use of push/pop mechanism mean that we lose all of the lemmas we have learnt prior to the call to yices_check_context_with_model_and_hint ?
There was a problem hiding this comment.
No, we will not lose the lemmas learned before calling the yices_check_context_with_model_and_hint method. The mcsat_pop method removes those lemmas that were learned after the last call to mcsat_push. Here we don't remove any lemmas because we didn't learn any between the push/pop call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.