Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I compared my implementation (evanw/thumbhash#8) with yours and couldn't find any obvious problems. Yours seems cleaner and more like a complete package, so I'm discarding my implementation.
I added a function
convertStringToHash
that complements yourconvertHashToString
.Just two suggestions:
encode
should be renamed to something likeRGBAToHash
to keep it similar to the complementary function namehashToRGBA
.thumbhash/src/Thumbhash.php
Line 281 in 0cfc704
I know that php 8.1 ist the current actively supported version and 7 is end of life, but a lot of real world projects still rely on older versions.
Thanks for your work on this!