fix: throw an Exception when GD can't decode the image data #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This throws a more descriptive exception when GD fails to decode the image, which is likely to be because GD doesn't have support for that image type. Before, it would just fail on the subsequent call to imagesx().
|
Hi! Thanks for the contribution. Before merging, can you provide an image that is failing so we can write a test for that? |
|
You don't need a specific image, you can just feed it any non-image data, like |
|
Fair enough. I added tests. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws a more descriptive exception when GD fails to decode the image, which is likely to be because GD doesn't have support for that image type. Before, it would just fail on the subsequent call to imagesx().