Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gluon checkins are not showing the changeset created #24

Closed
mrcatacroquer opened this issue May 30, 2017 · 4 comments
Closed

Gluon checkins are not showing the changeset created #24

mrcatacroquer opened this issue May 30, 2017 · 4 comments
Assignees

Comments

@mrcatacroquer
Copy link

While working with a Gluon workspace if you try to checkin a set of changes you'll see how after the "The selected items are about to be checked in. Please wait..." message there's nothing after it.

It would be nice a checkin confirmation in order to know the checkin operation took place.

@SRombauts
Copy link
Owner

Presently, the popup simply displays the last line of output from 'cm', which is working nicely for normal workspaces.

When in partial/Gluon mode, this is what I get from the command line:

The selected items are about to be checked in. Please wait ...

From the plugin point of view, the checkin is finished and successful, but the 'cm' cli is not giving us the expected output.

So should I switch to display a status info (from the 'cm status' command executed just after) ?

@SRombauts SRombauts self-assigned this May 30, 2017
@SRombauts SRombauts added this to In Progress in Plastic SCM UE4 May 30, 2017
@mrcatacroquer
Copy link
Author

That's a good one! I wasn't aware the ci was not telling us the changeset created.

In that case I think you can just notify a "Checking finished correctly" or something similar when the ci command returns.

@SRombauts
Copy link
Owner

So I kept the best of each world:

  1. in normal workspace, the last line starts with a "Created changeset" and is displayed as-is, as before
  2. in partial/gluon mode, the popup now says "Changeset submitted successfully."

@SRombauts SRombauts moved this from In Progress to Done in Plastic SCM UE4 May 30, 2017
@mrcatacroquer
Copy link
Author

Great! :)

SRombautsU added a commit that referenced this issue Apr 27, 2022
Fix Locked & Not-at-head status erased on "Submit content"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants