This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
[MIRROR] [bounty code moment] Adds a way to view the 'Server's Last Round' #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5646) * Adds "View Last Server Round Report" option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#55646
About The Pull Request
Adds an option to view the last round of a given server, rather than the last round by your own client. This is accomplished by logging the HTML round-end reports, and placing a copy representing the last one in a fixed directory (to be overwritten each shift).
Why It's Good For The Game
More logging, per headmin request
https://tgstation13.org/phpBB/viewtopic.php?f=41&t=27656#p577600
Changelog
🆑
add: You can now view a server's last round (not just yours specifically) via the OOC tab > Server's Last Round
/:cl:
I want to make sure this is done the right way, as modifying logs is a first for me. I've gotten maintainer go-ahead to add the round-end reports to our logs, but I want to make sure this specific implementation for the whole 'track the last round-end report" thing is solid. I fiddled with dynamically finding the last round's report by writing a weird recursive filebrowser algorithm, but so many edge-cases started popping up that I pivoted to storing a copy of the file in a fixed space, which turned out to be much cleaner.