Restart ffs #46
Open
Restart ffs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We're currently reviewing this to incorporate it into the next release of SSAGES. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's aim is to fix a bug that arises during a restart calculation in the FFS method with "computeInitialFlux": false. This problem is mentioned by zheng001a in Issue 38. If I don't mistake, the reason is that the value _N[0] was used during the first initialization of the queue, which is not defined in this case. To avoid it I've introduced a new variable, NLastSuccessful, which stores the number of successful trial runs saved on the last surface reached.
In addition, trial runs always started with zeroth surface at restart. I've changed the way of generating Lambda0ConfigLibrary, it seems works well, but may be this is not the best way.
I'm newbie in programming but I hope these changes will be useful.