Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use nanmedian instead #4

Open
jorgemarpa opened this issue May 19, 2022 · 0 comments
Open

use nanmedian instead #4

jorgemarpa opened this issue May 19, 2022 · 0 comments
Assignees
@christinahedges
Labels
bug Something isn't working

Comments

@jorgemarpa
Copy link
Contributor

kbackground/src/kbackground/kbackground.py

Line 192 in 4a2de61

self.model -= np.median(self.model)

Because self.weights can contain 0 values, dividing by the weights could lead to nan values and therefore this median operation should be np.nanmedian() instead.
@jorgemarpa jorgemarpa added the bug Something isn't working label May 19, 2022
christinahedges added a commit that referenced this issue May 20, 2022
@christinahedges
fixes #4
1b000e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christinahedges christinahedges

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgemarpa @christinahedges