#310 fix(event): adding kebab-case public events (#361)

SSENSE · Mar 21, 2019 · 649b9b2 · 649b9b2
1 parent c7a3a1f
commit 649b9b2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -102,7 +102,7 @@ export default {
 | `navigation-click`             |         | Carousel | Emits when the a navigation button is clicked, with the current direction (`backward` or `forward`)                                                                                                                                                                                                                     |
 | `pagination-click`             |         | Carousel | Emits when a pagination button is clicked, with the current `pageNumber`                                                                                                                                                                                                                        |
 | `page-change`                 | Number  | Carousel | Emits with the current page number.                                                                                                                                                                                                                       |
-| `slide-click`                | Object  | Slide    | Emits with the *dataset* object of the selected element                        ··                                                                
+| `slide-click`                | Object  | Slide    | Emits with the *dataset* object of the selected element                        ··
 | `transition-start` | | Carousel | Emits when the transition end is reached                                                                                                                                                  |
 | `transition-end`             |         | Carousel | Emits when the transition start is reached                                                                                                     ·                                                                                                               |
 

diff --git a/docs/source/api/index.md b/docs/source/api/index.md
@@ -322,3 +322,5 @@ Emits when a pagination button is clicked, with the current `pageNumber`
 
 * **Type**: `Number`
 * **Emitter**: `Carousel`
+
+> Lowercase versions of the above events are also emitted, namely—`pagechange`, `slideclick`, `transitionstart` and `transitionend`.
diff --git a/play/index.js b/play/index.js
@@ -249,6 +249,7 @@ play("Carousel", module)
     }
   })
   .add("With local event on pageChange", {
+  .add("pageChange event", {
     template:
       `<div style="width: 100%; display: flex; justify-content: center; margin-top: 40px;">
         <carousel style="width: 500px;" @pageChange="onPageChange">
@@ -381,6 +382,7 @@ play("Carousel", module)
     template:
       `<div style="width: 100%; display: flex; justify-content: center; margin-top: 40px;">
         <carousel style="width: 500px;" :navigateTo="navigateTo" :scrollPerPage=false v-on:pagechange="pageChanged">
+        <carousel style="width: 500px;" :navigateTo="newSlide" :scrollPerPage=false v-on:pagechange="pageChanged">
           <slide v-for="slide in slides" :key="slide.src">
             <img style="width: 100%;" :src= slide />
           </slide>
@@ -402,15 +404,6 @@ play("Carousel", module)
         slides: images
       }
     },
-    computed: {
-      navigateTo() {
-        if (this.newSlideAnimation)
-          return this.newSlide
-
-        else
-          return [this.newSlide, false]
-      }
-    },
     methods: {
       gotoSlide(val, animation) {
         this.newSlideAnimation = (animation === false ? false : true);