Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Right-to-Left Support for scrolling #195

Closed
lafeer opened this issue May 8, 2018 · 11 comments
Closed

Feature: Add Right-to-Left Support for scrolling #195

lafeer opened this issue May 8, 2018 · 11 comments
Labels
feature good first issue This issue is good for a new vue developer! help wanted

Comments

@lafeer
Copy link

lafeer commented May 8, 2018

Right-to-left support for slider. Currently, if the dir has been set to 'rtl', only the first slide is visible and you can't slide to the left where subsequent slides are being loaded. You can only scroll right onto blank slides.

Would be awesome to have this feature to cater to the Middle Eastern market!

@Mobeidat
Copy link

Mobeidat commented May 8, 2018

Yes please, it would be great to have it.

Thanks

@quinnlangille
Copy link
Member

Hey @lafeer that seems like an easy enough fix, just to confirm you'd like to see an :rtl=true/false prop which changes scrolling direction?

@lafeer
Copy link
Author

lafeer commented May 10, 2018

Yes, precisely! Thanks Quinn

@quinnlangille
Copy link
Member

quinnlangille commented May 10, 2018

Cool! Going to switch this to a feature request :~)

@quinnlangille quinnlangille added help wanted feature good first issue This issue is good for a new vue developer! labels May 10, 2018
@quinnlangille quinnlangille changed the title RTL support Feature: Add Right-to-Left Support for scrolling May 10, 2018
@saraElsanan
Copy link

is this feature has been added ?? because it's not working with me

@quinnlangille
Copy link
Member

@saraElsanan no it hasn't been added yet, this is just a feature request asking for a contributors help in developing it. Once it's been added, I'll comment here and close this issue :~)

@BocchiTheCode
Copy link
Contributor

BocchiTheCode commented Sep 7, 2018

I have made this feature but the user will still have to use navigateTo to shift to the last slide or they can simply set loop to true. Will that be okay?

@quinnlangille
Copy link
Member

Hmm, I think we should have the scrolling work the same wether it's right or left. It will likely just take some conditional logic inside the advancePage. It seems like we'll just need to add a +1 or -1 to slide index when rtl is enabled. Does that sound doable?

@amigogobara
Copy link

Ok I wanna use RTL
how can I use the latest features added?

@quinnlangille
Copy link
Member

@amigogobara the feature is still in PR phase, I'll post here once it's been merged into a release

quinnlangille pushed a commit that referenced this issue Sep 10, 2018
Feat: #184

Feat: #195

Revert "Feat: #195"

This reverts commit 961ce8b.
quinnlangille pushed a commit that referenced this issue Oct 19, 2018
Feat: #184 (#283)

Feat: #184

Feat: #195

Revert "Feat: #195"

This reverts commit 961ce8b.

Feat: #195

v0.14.0
@quinnlangille
Copy link
Member

quinnlangille commented Oct 19, 2018

Hey guys, just merged in @utkarshnag's PR - RTL scrolling is now enabled! Check the docs or #284 for more info.

p.s I'm going to be doing a documentation overhaul over the next week or so, feel free to make any suggestions here (#262) if you end up reading through them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue This issue is good for a new vue developer! help wanted
Projects
None yet
Development

No branches or pull requests

6 participants