Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transition hook function #168

Merged
merged 4 commits into from
Apr 17, 2018
Merged

Add transition hook function #168

merged 4 commits into from
Apr 17, 2018

Conversation

RyanLiu0235
Copy link
Contributor

Add transition end hook. With this hook, we'll be able to do some customized work like initiating the next page.

…reDestroy`

only `beforeCreate` and `created` will have server-side condition
@coveralls
Copy link

coveralls commented Apr 16, 2018

Coverage Status

Coverage decreased (-0.4%) to 71.831% when pulling d618af1 on stop2stare:transition-hook into ad50e2d on SSENSE:master.

@RyanLiu0235
Copy link
Contributor Author

@quinnlangille resolved.

@RyanLiu0235
Copy link
Contributor Author

RyanLiu0235 commented Apr 17, 2018

@quinnlangille OMG, I was just resolving conflicts... And you merged master.🤣

@quinnlangille
Copy link
Member

@stop2stare oh no! I can revert if it's an issue, it was just a whitespace difference so I resolved instead of pinging you haha lmk if you want me to undo

@RyanLiu0235
Copy link
Contributor Author

@quinnlangille haha, it's ok. Just merge this PR.

@quinnlangille quinnlangille merged commit 87b9c86 into SSENSE:master Apr 17, 2018
@RyanLiu0235 RyanLiu0235 deleted the transition-hook branch April 17, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants