Create KMS managed policy to decouple key id from app #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogfish
commented
May 24, 2020
| @@ -92,24 +92,96 @@ Once key is created in your account. It is re-usable across stacks: | |||
| */ | |||
| export class SymmetricKey extends kms.Key { | |||
| public readonly alias: kms.IAlias | |||
| public readonly accessPolicy: iam.IManagedPolicy | |||
|
|
|||
| constructor(scope: cdk.Construct, id: string, props: kms.KeyProps = {}) { | |||
| const { alias, ...other } = props | |||
| const keyAlias = alias || `alias/${id}` | |||
| super(scope, id, symmetricKeyProps({ alias: keyAlias, ...other })) | |||
|
|
|||
There was a problem hiding this comment.
Define managed policy attribute per policy instance
fogfish
commented
May 24, 2020
doc/kms-key.md
Outdated
| CMK and IAM policies are a framework to grant access for usage of keys. The default policy enables the root user in the account and allows to attach IAM policies. For each symmetric key, the library creates managed policies to enforce least privilege. Your application can re-use one of the following policy: | ||
| * `allow-encrypt-MyKey` | ||
| * `allow-decrypt-MyKey` | ||
| * `allow-crypto-MyKey` |
There was a problem hiding this comment.
Comment purpose of each policy
fogfish
commented
May 24, 2020
| ```typescript | ||
| c3.kms.fromAlias(stack, 'alias/MyKey') | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Clarify a role of alias for frequent key rotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.