Integrate idp-client and ueba endpoints to SDK #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 84408d2 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
cuongssh
requested changes
Nov 21, 2022
api/connectionmanager/client.go
Outdated
|
|
||
| // CreateIdForUebaScript create session ID for Ueba setup script | ||
| func (store *ConnectionManager) CreateIdForUebaScript() (map[string]string, error) { | ||
| sessionId := make(map[string]string) |
There was a problem hiding this comment.
Maybe replace the map with a generic created object response model. Same for all map[string]string usage below.
There was a problem hiding this comment.
You meant the struct to be model to be sth like this, right?:
type sessionID struct {
ID string `json:"id"
}
sure, I will change that.
I was not aware of the convention we follow here, so in the beginning, I weighed in between "using the map" or "using a struct model with a single field". In fact, I first created the struct model, but I ultimately got lured into using the map.
My kind of reasoning was,
- The return type has only one "key-value" pair, so I thought maybe a map could just fit the case.
- Since, this "struct" model will only be used once in the entire code. I didn't see the advantage we can get relating to reusability, so I kind of inclined towards the map.
But yes, I will change it.
…propriate method names
cuongssh
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.