-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate sessions-storage apis from v27 #129
Integrate sessions-storage apis from v27 #129
Conversation
something seemed to have changed in the staticcheck library |
@@ -87,3 +87,84 @@ func (store *Auth) RegenerateIdpClientConfig(idpID string) (*IdpClientConfig, er | |||
|
|||
return clientConfig, err | |||
} | |||
|
|||
// UserSessions fetches valid sessions by userID. | |||
func (store *Auth) UserSessions(offset, limit int, sortkey, sortdir, userID string) (*sessionsResult, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
} | ||
|
||
// SourceSessions fetches valid sessions by sourceID. | ||
func (store *Auth) SourceSessions(offset, limit int, sortkey, sortdir, sourceID string) (*sessionsResult, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
resolves the issue because github action parses for eg, unquoted 1.20 as 1.2, quoting it solves the issue
Code Climate has analyzed commit dd0b11a and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.