If previous SRV query failed, the next try might not be retried in some cases

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/1886

• Created at 2013-04-19 11:15:47 by jhrozek
• Closed as Fixed
• Assigned to pbrezina
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=954275

---

If a SRV query is attempted after the previous resolution if this query failed, but before the retry timeout, the next server is not even retried.

Code-wise this is because the failover request returns EIO and a NULL server and the be_fo_ request above gets trapped by this condition:

587         /* mark server as bad and retry */       
588         if (!state->srv) {
589             return EFAULT;
590         }                 

I think the failover request should return the SRV "meta-server" even if it wasn't retried so the caller can mark it as bad.

Comments

---

Comment from jhrozek at 2013-04-22 10:27:39

Linked to Bugzilla bug: https://bugzilla.redhat.com/show_bug.cgi?id=954275 (Red Hat Enterprise Linux 6)

rhbz: => [https://bugzilla.redhat.com/show_bug.cgi?id=954275 954275]

---

Comment from dpal at 2013-04-25 15:51:44

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.10 beta

---

Comment from dpal at 2013-05-13 15:16:13

Fields changed

milestone: SSSD 1.10 beta => SSSD 1.10.0

---

Comment from jhrozek at 2013-05-15 14:23:51

This is affecting production environments.

priority: major => critical

---

Comment from pbrezina at 2013-06-12 10:14:15

Fields changed

changelog: =>
owner: somebody => pbrezina
status: new => assigned

---

Comment from pbrezina at 2013-06-13 10:37:15

Fields changed

patch: 0 => 1

---

Comment from jhrozek at 2013-06-14 14:14:32

• master: d3b39cf

resolution: => fixed
status: assigned => closed

---

Comment from jhrozek at 2013-06-17 09:44:25

• sssd-1-9: 5e0f0c4

---

Comment from jhrozek at 2013-11-06 20:24:57

Fields changed

changelog: => N/A, just a bugfix

---

Comment from jhrozek at 2017-02-24 14:23:51

Metadata Update from @jhrozek:

• Issue assigned to pbrezina
• Issue set to the milestone: SSSD 1.10.0