Dereference before NULL check in nscd.c

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/1971

• Created at 2013-06-07 07:41:57 by jhrozek
• Closed as Fixed
• Assigned to okos

---

193

CID 11852: Dereference before null check (REVERSE_INULL) [select issue]
   
CID 11853: Dereference before null check (REVERSE_INULL) [select issue]
   
CID 11851: Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking "entry" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
194        if (entry   != NULL &&
195            service != NULL &&
196            enabled != NULL) {

Comments

---

Comment from jhrozek at 2013-06-07 07:44:18

I suggested the NULL checks during code review but reading the code now more carefully the worst case that can happen is that all pointers will point to "line" so maybe the checks can be removed. Please test with malformed lines (two out of three valid keywords etc).

---

Comment from jhrozek at 2013-06-07 07:45:34

Fields changed

coverity: 11851 => 11851,11852

---

Comment from jhrozek at 2013-06-07 07:50:45

Fields changed

coverity: 11851,11852 => 11851,11852,11853

---

Comment from okos at 2013-06-07 14:44:01

Fields changed

patch: 0 => 1
status: new => assigned

---

Comment from jhrozek at 2013-06-10 11:43:19

A Coverity bug can be moved to 1.10 beta directly w/o waiting on the triage.

• master: 55d1a46

milestone: NEEDS_TRIAGE => SSSD 1.10 beta
resolution: => fixed
status: assigned => closed

---

Comment from jhrozek at 2013-06-13 16:19:56

Fields changed

rhbz: => 0

---

Comment from jhrozek at 2017-02-24 14:54:49

Metadata Update from @jhrozek:

• Issue assigned to okos
• Issue set to the milestone: SSSD 1.10 beta