Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache_req tests don't use leak_check_push/leak_check_pop in fixtures #3910

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed
Assignees
Labels
Closed: Fixed Issue was closed as fixed.

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/2869

  • Created at 2015-11-14 13:07:47 by jhrozek
  • Closed as Fixed
  • Assigned to pbrezina

During review of patches for #2730, we noticed the tests should use check_leaks_push/pop in the test fixtures to catch issues where memory was allocated on long-living contexts (like responder or event context).

Comments


Comment from jhrozek at 2015-11-18 09:52:08

Triage notes - this should be a prerequisite for using cache_req in responders (#1126) which is currently 1.14.


Comment from jhrozek at 2015-11-19 15:42:00

For the time being, filing into 1.14 beta, we will decide if there is still time to use cache_req in 1.14 or whether we need to move that enhancement to 1.15..

milestone: NEEDS_TRIAGE => SSSD 1.14 beta


Comment from jhrozek at 2015-12-03 22:15:04

Fields changed

rhbz: => 0


Comment from jhrozek at 2016-02-16 12:43:34

Pavel agreed on IRC to fix this ticket.

owner: somebody => pbrezina


Comment from pbrezina at 2016-02-16 12:44:44

Fields changed

status: new => assigned


Comment from pbrezina at 2016-02-18 14:51:22

Fields changed

patch: 0 => 1


Comment from jhrozek at 2016-03-14 17:53:45


Comment from jhrozek at 2016-06-20 11:37:57

Fields changed

milestone: SSSD 1.14 beta => SSSD 1.14 alpha
resolution: => fixed
status: assigned => closed


Comment from jhrozek at 2017-02-24 14:52:47

Metadata Update from @jhrozek:

@sssd-bot sssd-bot added the Closed: Fixed Issue was closed as fixed. label May 2, 2020
@sssd-bot sssd-bot closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed: Fixed Issue was closed as fixed.
Projects
None yet
Development

No branches or pull requests

2 participants