Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sssd syslog/journal logging is now too generic #5384

Closed
alexey-tikhonov opened this issue Nov 3, 2020 · 1 comment
Closed

sssd syslog/journal logging is now too generic #5384

alexey-tikhonov opened this issue Nov 3, 2020 · 1 comment
Assignees
@alexey-tikhonov
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.

Comments

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 3, 2020 •
edited
Loading

Cloned from RHBZ:

Description of problem:

Before log messages were like:

Oct 14 07:11:30 hostname sssd[1244]: Starting up
Oct 14 07:11:31 hostname sssd[sudo][1411]: Starting up
Oct 14 07:11:31 hostname sssd[ssh][1413]: Starting up
Oct 14 07:11:31 hostname sssd[autofs][1414]: Starting up
Oct 14 07:11:31 hostname sssd[nss][1410]: Starting up
Oct 14 07:11:31 hostname sssd[pam][1412]: Starting up
Oct 14 07:11:31 hostname sssd[pac][1415]: Starting up

Now they are like:

Oct 14 07:41:22 hostname sssd[21141]: Starting up
Oct 14 07:41:22 hostname ssh[21161]: Starting up
Oct 14 07:41:22 hostname nss[21158]: Starting up
Oct 14 07:41:22 hostname pam[21160]: Starting up

This is too generic - in particular the "pam" line which gets picked up by logwatch as PAM messages.

Version-Release number of selected component (if applicable):
sssd-1.16.5-10.el7_9.5.x86_64
@alexey-tikhonov alexey-tikhonov self-assigned this Nov 3, 2020
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Nov 3, 2020
@alexey-tikhonov
DEBUG: fixes program identifier as seen in syslog
69972eb 
Commit 225fe99 changed `debug_prg_name`
to accomodate needs of own SSSD logs, but this affected journal/syslog
as well.

This patch amends situation:
 - journal messages gets "umbrella" identifier "sssd[]"
 - syslog uses default which is program name

Resolves: SSSD#5384
@alexey-tikhonov alexey-tikhonov linked a pull request Nov 3, 2020 that will close this issue
DEBUG: fixes program identifier as seen in syslog #5373
Closed
pbrezina pushed a commit that referenced this issue Nov 5, 2020
@alexey-tikhonov @pbrezina
DEBUG: fixes program identifier as seen in syslog
647a130 
Commit 225fe99 changed `debug_prg_name`
to accomodate needs of own SSSD logs, but this affected journal/syslog
as well.

This patch amends situation:
 - journal messages gets "umbrella" identifier "sssd[]"
 - syslog uses default which is program name

Resolves: #5384

Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 1823353)
@pbrezina
Copy link
Member

pbrezina commented Nov 5, 2020

Pushed PR: #5373

  • master
    • 1823353 - DEBUG: fixes program identifier as seen in syslog
    • 833034f - DEBUG: journal_send() was made static
  • sssd-1-16
    • 647a130 - DEBUG: fixes program identifier as seen in syslog
    • 208372c - DEBUG: journal_send() was made static

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Nov 5, 2020
elkoniu pushed a commit to elkoniu/sssd that referenced this issue Feb 28, 2021
@alexey-tikhonov @elkoniu
DEBUG: fixes program identifier as seen in syslog
0e70177 
Commit 225fe99 changed `debug_prg_name`
to accomodate needs of own SSSD logs, but this affected journal/syslog
as well.

This patch amends situation:
 - journal messages gets "umbrella" identifier "sssd[]"
 - syslog uses default which is program name

Resolves: SSSD#5384

Reviewed-by: Tomáš Halman <thalman@redhat.com>
akuster pushed a commit to akuster/sssd that referenced this issue May 18, 2021
@alexey-tikhonov @akuster
DEBUG: fixes program identifier as seen in syslog
02cdacd 
Commit 225fe99 changed `debug_prg_name`
to accomodate needs of own SSSD logs, but this affected journal/syslog
as well.

This patch amends situation:
 - journal messages gets "umbrella" identifier "sssd[]"
 - syslog uses default which is program name

Resolves: SSSD#5384

Reviewed-by: Tomáš Halman <thalman@redhat.com>
etrunko pushed a commit to etrunko/sssd that referenced this issue Nov 16, 2023
@alexey-tikhonov @etrunko
DEBUG: fixes program identifier as seen in syslog
3346c35 
Commit 225fe99 changed `debug_prg_name`
to accomodate needs of own SSSD logs, but this affected journal/syslog
as well.

This patch amends situation:
 - journal messages gets "umbrella" identifier "sssd[]"
 - syslog uses default which is program name

Resolves: SSSD#5384

Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 1823353)
etrunko pushed a commit to etrunko/sssd that referenced this issue Nov 16, 2023
@alexey-tikhonov @etrunko
DEBUG: fixes program identifier as seen in syslog
40d6d7c 
Commit 225fe99 changed `debug_prg_name`
to accomodate needs of own SSSD logs, but this affected journal/syslog
as well.

This patch amends situation:
 - journal messages gets "umbrella" identifier "sssd[]"
 - syslog uses default which is program name

Resolves: SSSD#5384

Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 1823353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-tikhonov alexey-tikhonov

Labels
Bugzilla Closed: Fixed Issue was closed as fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEBUG: fixes program identifier as seen in syslog alexey-tikhonov/sssd
2 participants
@pbrezina @alexey-tikhonov