Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing search index for originalADgidNumber #5430

Closed
alexey-tikhonov opened this issue Dec 4, 2020 · 10 comments
Closed

Missing search index for originalADgidNumber #5430

alexey-tikhonov opened this issue Dec 4, 2020 · 10 comments
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.

Comments

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Dec 4, 2020 •
edited
Loading

Commits 03bc962 (2.x) / 80e6f71 (1.16) introduced a
search where one attribute in the filter (namely originalADgidNumber) does not have an index.

This results in performance regression.
@alexey-tikhonov
Copy link
Member Author

This was reported on a user mailing list with the following data:

Sample Program: get_user_groups.py
    - it just call getgrouplist of a user supplied using libc

Old env -
OS Linux 3.10.0-1127.19.1.el7.x86_64 #1 SMP Wed Aug 26 11:48:49 BST 2020 x86_64 x86_64 x86_64 GNU/Linux
SSSD Version    - 1.16.4-37.el7_8.4.x86_64
ID  879 'Initgroups by name' testuser1@example
    lookup_time 0.031922 sec

New env
OS Linux 3.10.0-1160.6.1.el7.x86_64 #1 SMP Wed Nov 18 22:40:48 GMT 2020 x86_64 x86_64 x86_64 GNU/Linux
SSSD Version    - 1.16.5-10.el7_9.5.x86_64
ID  776 'Initgroups by name' testuser1@example
    lookup_time 0.123359 sec

@joakim-tjernlund
Copy link
Contributor

Would be nice with a PR fixing this regression too.

@joakim-tjernlund
Copy link
Contributor

ping?

@alexey-tikhonov
Copy link
Member Author

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1909373

@joakim-tjernlund
Copy link
Contributor

Workaround as per upstream

# ldbmodify -H /var/lib/sss/db/cache_YOUR.DOMAIN.NAME.ldb -s base -b '@INDEXLIST' << END_END
dn: @INDEXLIST
changetype: modify
add: @IDXATTR
@IDXATTR: originalADgidNumber
END_END

elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 6, 2021
@elkoniu
SYSDB: Add missing sysdb attribute
69993f6 
In some search scenarios for AD sysdb lookup was
performed against non existing database index.
This result in search performance drop.

This PR adds missing search index: originalADgidNumber

Resolves: SSSD#5430
@elkoniu elkoniu mentioned this issue Jul 6, 2021
Closed
elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 8, 2021
@elkoniu
SYSDB: Add search index
f70cbb1 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

Resolves: SSSD#5430
elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 9, 2021
@elkoniu
SYSDB: Add search index "originalADgidNumber"
ebe6e1a 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

Resolves: SSSD#5430
elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 12, 2021
@elkoniu
SYSDB: Add search index "originalADgidNumber"
7fd3f2e 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430
@pbrezina
Copy link
Member

Pushed PR: #5701

  • master
    • 17e339d - SYSDB: Add search index "originalADgidNumber"

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Jul 12, 2021
@alexey-tikhonov
Copy link
Member Author

@elkoniu , please, backport to 1-16 branch.

elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 20, 2021
@elkoniu
SYSDB: Add search index "originalADgidNumber"
016e545 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430
@elkoniu elkoniu mentioned this issue Jul 20, 2021
Closed
@elkoniu
Copy link
Contributor

elkoniu commented Jul 20, 2021

@alexey-tikhonov PR created: #5721

@elkoniu elkoniu linked a pull request Jul 20, 2021 that will close this issue
SYSDB: Add search index "originalADgidNumber" #5721
Closed
elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 21, 2021
@elkoniu
SYSDB: Add search index "originalADgidNumber"
4cea41d 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430
@alexey-tikhonov
Copy link
Member Author

@alexey-tikhonov PR created: #5721

Thank you.

elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 21, 2021
@elkoniu
SYSDB: Add search index "originalADgidNumber"
cfbb982 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>

(cherry picked from commit 17e339d)
elkoniu added a commit to elkoniu/sssd that referenced this issue Jul 21, 2021
@elkoniu
SYSDB: Add search index "originalADgidNumber"
f798230 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>

(cherry picked with changes from commit 17e339d)
pbrezina pushed a commit that referenced this issue Jul 22, 2021
@elkoniu @pbrezina
SYSDB: Add search index "originalADgidNumber"
c4b1b82 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: #5430

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>

(cherry picked with changes from commit 17e339d)

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
@pbrezina
Copy link
Member

Pushed PR: #5721

  • sssd-1-16
    • c4b1b82 - SYSDB: Add search index "originalADgidNumber"

etrunko pushed a commit to etrunko/sssd that referenced this issue Nov 16, 2023
@elkoniu @etrunko
SYSDB: Add search index "originalADgidNumber"
6c83c61 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>

(cherry picked with changes from commit 17e339d)

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
etrunko pushed a commit to etrunko/sssd that referenced this issue Nov 16, 2023
@elkoniu @etrunko
SYSDB: Add search index "originalADgidNumber"
33e373f 
Commit 03bc962 introduced a change which can result in
unindexed search in some scenarios. The result is performance
drop comparing to older SSSD version.

This PR adds missing search index: originalADgidNumber

:relnote: Add search index "originalADgidNumber" to SYSDB

Resolves: SSSD#5430

Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>

(cherry picked with changes from commit 17e339d)

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.
Projects
None yet
Milestone
No milestone
4 participants
@elkoniu @joakim-tjernlund @pbrezina @alexey-tikhonov