Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of glib2 for Unicode processing #5767

Closed
alexey-tikhonov opened this issue Sep 1, 2021 · 2 comments
Closed

Drop support of glib2 for Unicode processing #5767

alexey-tikhonov opened this issue Sep 1, 2021 · 2 comments
Assignees
@alexey-tikhonov
Labels
Closed: Fixed Issue was closed as fixed.

Comments

@alexey-tikhonov
Copy link
Member

Currently SSSD supports two libraries for Unicode processing (configured via --with-unicode-lib): glib and libunistring.

glib is a huge project, pulling it as a dependency for such a limited use doesn't look justified. libunistring, on the other hand, is a specialized library that should be widely available.

Thus dropping support of glib2 for Unicode processing seems reasonable.
@alexey-tikhonov alexey-tikhonov self-assigned this Sep 1, 2021
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Sep 1, 2021
@alexey-tikhonov
UNICODE: drop support of glib2 for Unicode processing
6e0afe6 
:relnote: This release drops support of `--with-unicode-lib` configure option.
`libunistring` will be used unconditionally for Unicode processing.

Resolves: SSSD#5767
@alexey-tikhonov alexey-tikhonov linked a pull request Sep 1, 2021 that will close this issue
Sources cleanup. #5754
Closed
@pbrezina
Copy link
Member

pbrezina commented Sep 2, 2021

Pushed PR: #5754

  • master
    • 6acb1d6 - UNICODE: drop support of glib2 for Unicode processing
    • c037432 - BUILD: get rid of PCRE support

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Sep 2, 2021
@joakim-tjernlund
Copy link
Contributor

joakim-tjernlund commented Sep 3, 2021 •
edited
Loading

Unfortunately this broke sssd on Gentoo, see #5772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-tikhonov alexey-tikhonov

Labels
Closed: Fixed Issue was closed as fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sources cleanup. alexey-tikhonov/sssd
3 participants
@joakim-tjernlund @pbrezina @alexey-tikhonov