Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sssd-sudo missing debug statement in its .service file #6920

Closed
Alphix opened this issue Sep 10, 2023 · 4 comments
Closed

sssd-sudo missing debug statement in its .service file #6920

Alphix opened this issue Sep 10, 2023 · 4 comments
Assignees
@alexey-tikhonov
Labels
Closed: Fixed Issue was closed as fixed. Future work

Comments

@Alphix
Copy link
Contributor

Alphix commented Sep 10, 2023

The sssd-sudo.service.in file has this ExecStart definition:

sssd/src/sysv/systemd/sssd-sudo.service.in

Line 15 in 3765340

ExecStart=@libexecdir@/sssd/sssd_sudo --socket-activated

But other .service files look like this (two examples):

sssd/src/sysv/systemd/sssd-ssh.service.in

Line 15 in 3765340

ExecStart=@libexecdir@/sssd/sssd_ssh ${DEBUG_LOGGER} --socket-activated

sssd/src/sysv/systemd/sssd-nss.service.in

Line 14 in 3765340

ExecStart=@libexecdir@/sssd/sssd_nss ${DEBUG_LOGGER} --socket-activated

Note the missing ${DEBUG_LOGGER} in sssd-sudo.service.in, which means that a log file won't be generated.
@alexey-tikhonov
Copy link
Member

There is #6919 to fix this.

@alexey-tikhonov alexey-tikhonov self-assigned this Sep 11, 2023
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Sep 11, 2023
@alexey-tikhonov
SUDO service: ${DEBUG_LOGGER} was missed for 'sudo'
24df422 
service in a7277fe

Resolves: SSSD#6920
@Alphix
Copy link
Contributor Author

Alphix commented Sep 11, 2023

There is #6919 to fix this.

Ah, great, thanks, I missed that (I did search through the issues and PRs...but I seem to have missed this).

@alexey-tikhonov
Copy link
Member

Pushed PR: #6919

  • master
    • 01bee47 - SUDO service: ${DEBUG_LOGGER} was missed for 'sudo'

@alexey-tikhonov alexey-tikhonov added the Closed: Fixed Issue was closed as fixed. label Sep 26, 2023
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Sep 26, 2023
@alexey-tikhonov
SUDO service: ${DEBUG_LOGGER} was missed for 'sudo'
100dedf 
service in a7277fe

Resolves: SSSD#6920

Reviewed-by: Alejandro López <allopez@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit 01bee47)
@alexey-tikhonov alexey-tikhonov mentioned this issue Sep 26, 2023
Closed
alexey-tikhonov added a commit that referenced this issue Sep 26, 2023
@alexey-tikhonov
SUDO service: ${DEBUG_LOGGER} was missed for 'sudo'
b86d301 
service in a7277fe

Resolves: #6920

Reviewed-by: Alejandro López <allopez@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit 01bee47)

Reviewed-by: Alejandro López <allopez@redhat.com>
@alexey-tikhonov
Copy link
Member

Pushed PR: #6960

  • sssd-2-9
    • b86d301 - SUDO service: ${DEBUG_LOGGER} was missed for 'sudo'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-tikhonov alexey-tikhonov

Labels
Closed: Fixed Issue was closed as fixed. Future work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alphix @alexey-tikhonov