SECRETS: Shutdown the responder in case it becomes idle #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
force-pushed
the
wip/secrets_idle_timeout
branch
from
6ed1688
to
933c519
Compare
|
The code looks good and both the PAM responder and the secrets responder now exit on idle. ACK, I will push once CI and Coverity finish. |
|
Just a little nitpick.
The name of function `responder_get_idle_timer_config_option`
is a little bit confusing. I woudl expect that it will return value
of `idle_timer_config_option`. But it alse setup a timer (
`setup_responder_idle_timer`)
LS
|
|
@lslebodn: responder_setup_idle_timer_config() sounds better to you? |
|
On (07/03/17 03:55), fidencio wrote:
@lslebodn: responder_setup_idle_timer_config() sounds better to you?
absolutely
LS
|
As secrets responder will make use of this very same code in the future, let's wrap it up into a new function in order to avoid code duplication. Related: https://pagure.io/SSSD/sssd/issue/3316 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Similarly to what has been done for the other responders, let's shutdown the secrets responder in case it becomes idle. Resolves: https://pagure.io/SSSD/sssd/issue/3316 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
fidencio
force-pushed
the
wip/secrets_idle_timeout
branch
from
933c519
to
13214fd
Compare
|
CI with the new patch: http://sssd-ci.idm.lab.eng.brq.redhat.com:8080/job/ci/6416/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to what has been done for the other responders, let's shutdown the secrets responder in case it becomes idle.
Resolves:
https://pagure.io/SSSD/sssd/issue/3316