Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwbclient-sssd: update interface to version 0.14 #318

Closed
wants to merge 1 commit into from

Conversation

sumit-bose
Copy link
Contributor

The main change is a new member of the wbcAuthErrorInfo struct.

The main change is a new member of the wbcAuthErrorInfo struct.
@fidencio
Copy link
Contributor

@sumit-bose: what's the best way to test this change?

@fidencio
Copy link
Contributor

[root@master x86_64]# rpm -q libwbclient
libwbclient-4.7.0-0.7.rc3.fc27.x86_64

[root@master x86_64]# rpm -ql libwbclient
/usr/lib64/samba/libwinbind-client-samba4.so
/usr/lib64/samba/wbclient/libwbclient.so.0
/usr/lib64/samba/wbclient/libwbclient.so.0.14

[root@master x86_64]# objdump -T /usr/lib64/samba/wbclient/libwbclient.so.0.14 | grep WBCLIENT_0.14
0000000000000000 g    DO *ABS*  0000000000000000  WBCLIENT_0.14 WBCLIENT_0.14

ACK!

@fidencio fidencio self-assigned this Jul 31, 2017
@fidencio
Copy link
Contributor

And, of course:

[root@master x86_64]# objdump -T /usr/lib64/sssd/modules/libwbclient.so.0.14.0  | grep WBCLIENT_0.14
0000000000000000 g    DO *ABS*  0000000000000000  WBCLIENT_0.14 WBCLIENT_0.14

Whoever is going to apply this patch, please, feel free to jump in and let me know if I missed something reviewing this patch.

@jhrozek
Copy link
Contributor

jhrozek commented Aug 3, 2017

I wouldn't test anything else myself.

Pushed to master: d1b2a33

@jhrozek jhrozek closed this Aug 3, 2017
@jhrozek jhrozek added the Pushed label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants