NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.13 #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack. Just the commit message still talkes about |
We've noticed some crashes that happened because gctx is already freed, but the timeout handler is still called. In order to avoid that, let's remove the timeout handler when netgr is freed at other places. Resolves: https://pagure.io/SSSD/sssd/issue/3523 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> (cherry picked from commit 67f739d)
fidencio
force-pushed
the
wip/nss_setnetgrent_timeout_1_13_patch
branch
from
8af7eb1
to
977486f
Compare
|
@pbrezina, thanks for the review. I've changed the commit message. |
|
Adding "Accepted" label per @pbrezina's review. |
|
Patch will be the same as in sssd-1-14 branch therefore closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed some crashes that happened because netgr is already freed,
but the timeout handler is still called. In order to avoid that, let's
remove the timeout handler when enum_ctx is freed at other places.
Resolves: https://pagure.io/SSSD/sssd/issue/3523
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com
(cherry picked from commit 67f739d)