Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad_gpo_ndr.c: more ndr updates #5184

Closed
wants to merge 1 commit into from
Closed

ad_gpo_ndr.c: more ndr updates #5184

wants to merge 1 commit into from

Conversation

sumit-bose
Copy link
Contributor

This patch add another update to the ndr code which was previously
updated by commit c031add and
1fdd8fa.

As missing update in ndr_pull_security_ace() cased
a failure in ad_gpo_parse_sd(). A unit-test for ad_gpo_parse_sd() was
added to prevent similar issues in future.

Resolves: #5183

@sumit-bose
ad_gpo_ndr.c: more ndr updates
dbe9d59 
This patch add another update to the ndr code which was previously
updated by commit c031add and
1fdd8fa.

As missing update in ndr_pull_security_ace() cased
a failure in ad_gpo_parse_sd(). A unit-test for ad_gpo_parse_sd() was
added to prevent similar issues in future.

Resolves: SSSD#5183
@chenxiaolong
Copy link
Contributor

chenxiaolong commented May 28, 2020 •
edited

(I'm the person who originally reported RHBZ#1840908 - linked to #5183)

I just rebuilt sssd 2.3.0-1.fc32.x86_64 with this patch included and I can confirm that this fixes the issue. Thank you!

@sumit-bose
Copy link
Contributor Author

(I'm the person who originally reported RHBZ#1840908 - linked to #5183)

I just rebuilt sssd 2.3.0-1.fc32.x86_64 with this patch included and I can confirm that this fixes the issue. Thank you!

Great, thanks for the feedback.

bye,
Sumit

@pbrezina pbrezina self-assigned this Jun 4, 2020
@pbrezina
Copy link
Member

pbrezina commented Jun 4, 2020

Thank you. Ack.

@pbrezina
Copy link
Member

pbrezina commented Jun 5, 2020

Pushed PR: #5184

  • master
    • a7c7556 - ad_gpo_ndr.c: more ndr updates

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Jun 5, 2020
@pbrezina pbrezina closed this Jun 5, 2020
@pbrezina pbrezina mentioned this pull request Jun 5, 2020
Closed
@suwalski
Copy link

suwalski commented Jun 14, 2022 •
edited

This issue seems to exist on sssd-2.4.1 in Debian. I have verified that the code from this pull is there in ad_gpo_ndr.c. Using the ad_gpo_access_control = disabled workaround does solve the issue.

Though I see that it's supposed to be properly fixed with sssd-2.7+ as per: https://bugzilla.redhat.com/show_bug.cgi?id=1839805#c28

So this is just a note. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbrezina pbrezina

Labels
Bugzilla Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sssd 2.3.0 breaks AD auth due to GPO parsing failure
5 participants
@sumit-bose @chenxiaolong @pbrezina @suwalski @alexey-tikhonov