Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of libnss as a crypto backend #5246

Closed
wants to merge 2 commits into from
Closed

Drop support of libnss as a crypto backend #5246

wants to merge 2 commits into from

Conversation

alexey-tikhonov
Copy link
Member

Resolves: #1041

@alexey-tikhonov
Copy link
Member Author

PR is marked as "WiP" because I plan to add another patch to rename misleading --nssdb arg of p11_child.

Still I posted it so that anyone interested could have a preliminary look.

alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this pull request Jul 21, 2020
@alexey-tikhonov
Get rid of "NSS DB" references.
efabca5 
Resolves: SSSD#5246
@alexey-tikhonov alexey-tikhonov force-pushed the drop-libnss-support branch 2 times, most recently from efabca5 to 7ede3a3 Compare July 21, 2020 17:11
@alexey-tikhonov alexey-tikhonov changed the title (WiP) Drop support of libnss as a crypto backend Drop support of libnss as a crypto backend Jul 21, 2020
@alexey-tikhonov
Copy link
Member Author

Somewhat related: https://bugzilla.redhat.com/show_bug.cgi?id=1846778

@alexey-tikhonov
Copy link
Member Author

Rebased on the latest master branch.

@pbrezina
Copy link
Member

Works as expected. There is just a left over call to WITH_CRYPTO macro on configure.ac. Since you removed the macro this should be removed as well.

@pbrezina pbrezina self-assigned this Aug 21, 2020
@alexey-tikhonov
Copy link
Member Author

There is just a left over call to WITH_CRYPTO macro on configure.ac. Since you removed the macro this should be removed as well.

Thanks for the catch. Fixed.

@pbrezina
Copy link
Member

Ack.

@pbrezina
Copy link
Member

Pushed PR: #5246

  • master
    • a291148 - Get rid of "NSS DB" references.
    • 266ecc0 - Drop support of libnss as a crypto backend

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Aug 27, 2020
@pbrezina pbrezina closed this Aug 27, 2020
@pbrezina pbrezina mentioned this pull request Aug 27, 2020
Closed
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this pull request Jan 11, 2021
@alexey-tikhonov
Removed leftovers after PR SSSD#5246
5af8e60
pbrezina pushed a commit that referenced this pull request Jan 18, 2021
@alexey-tikhonov @pbrezina
Removed leftovers after PR #5246
c48a4e8 
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
@pbrezina pbrezina mentioned this pull request Jan 18, 2021
Closed
akuster pushed a commit to akuster/sssd that referenced this pull request May 18, 2021
@alexey-tikhonov @akuster
Removed leftovers after PR SSSD#5246
e96b4d0 
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbrezina pbrezina

Labels
Bugzilla Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate and eventually get rid of support of NSS as a crypto backend
2 participants
@alexey-tikhonov @pbrezina