build: Don't use AC_CHECK_FILE when building manpages #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AC_CHECK_FILE does not support cross-compilation, and will only check the host rootfs. Replace AC_CHECK_FILE with a 'test -f <FILE>' instead, to allow building manpages when cross-compiling. Signed-off-by: Jonatan Pålsson <jonatan.p@gmail.com>
|
Hi, thanks for the patch, it looks like other projects had to do similar changes to allow cross-compilation. So, ACK. Btw, may I ask for which platform you are trying to cross-compile SSSD? bye, |
|
Hi,
Sure. I am building for x86 right now, using Yocto. The OpenEmbedded meta-security layer has support for SSSD. There's basic support for building manual pages (i.e. the right switch can be passed to the configure script), but when enabling it, I run in to the AC_CHECK_FILE issue which this patch fixes. I still need to do some work in the SSSD recipe in meta-security, but this patch is the first step. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC_CHECK_FILE does not support cross-compilation, and will only check
the host rootfs. Replace AC_CHECK_FILE with a 'test -f ' instead,
to allow building manpages when cross-compiling.
Signed-off-by: Jonatan Pålsson jonatan.p@gmail.com