KCM: Fix SSH GSSAPI delegation for the memory back end #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please add link to the ticket this PR resolves? |
|
@alexey-tikhonov hello, there is only a downstream BZ, should I create an associated upstream ticket to link to this PR? |
|
Yes, please. This is usually done for any non-trivial patch. |
When GSSAPI credentials are delegated over SSH, the KCM set default ccache operation looks for a ERR_NO_CREDS return code to continue handling the SSH-created ccache correctly. The memory back end will now return this error code in this situation, matching the default secdb back end. Resolves: SSSD#5333
justin-stephenson
force-pushed
the
kcm_ssh_gssapi_memory_storage_fix
branch
from
ff108aa
to
b93ad04
Compare
|
Cloned to #5333 and updated the commit message with this number. |
Thank you. |
|
Ack. Thank you. |
pbrezina
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GSSAPI credentials are delegated over SSH, the KCM set default ccache operation looks for a ERR_NO_CREDS return code to continue handling the SSH-created ccache correctly.
sssd/src/responder/kcm/kcmsrv_ops.c
Line 1762 in fbc7082
The memory back end will now return this error code in this situation, matching the default secdb back end. Note we already have a multihost for GSSAPI delegation with the default KCM back end.
The memory back end is only returning ERR_KCM_CC_END, so i'm not sure if we should be returning ERR_KCM_CC_END elsewhere.